-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed issue #306 #346
Fixed issue #306 #346
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @ykuijs)
source/DSCResources/DSC_ScheduledTask/DSC_ScheduledTask.psm1, line 459 at r1 (raw file):
{ Write-Verbose -Message ($script:localizedData.DisablingExistingScheduledTask -f $TaskName, $TaskPath) if ($PSVersionTable.PSVersion -gt [Version]"5.0.0.0")
Nitpick - can you add blank line before this and use single quotes around 5.0.0.0
? Also, can change [Version]
to[System.Version]
?
tests/Unit/DSC_ScheduledTask.Tests.ps1, line 226 at r1 (raw file):
It 'Should remove the scheduled task in the set method' { Set-TargetResource @testParameters if ($PSVersionTable.PSVersion -gt [Version]"5.0.0.0")
Nitpick - can you add blank line before this and use single quotes around 5.0.0.0
? Also, can change [Version]
to[System.Version]
?
tests/Unit/DSC_ScheduledTask.Tests.ps1, line 1584 at r1 (raw file):
It 'Should disable the scheduled task in the set method' { Set-TargetResource @testParameters if ($PSVersionTable.PSEdition -gt [Version]"5.0.0.0")
Nitpick - can you add blank line before this and use single quotes around 5.0.0.0
? Also, can change [Version]
to[System.Version]
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 3 files reviewed, 3 unresolved discussions (waiting on @PlagueHO)
source/DSCResources/DSC_ScheduledTask/DSC_ScheduledTask.psm1, line 459 at r1 (raw file):
Previously, PlagueHO (Daniel Scott-Raynsford) wrote…
Nitpick - can you add blank line before this and use single quotes around
5.0.0.0
? Also, can change[Version]
to[System.Version]
?
Done.
tests/Unit/DSC_ScheduledTask.Tests.ps1, line 226 at r1 (raw file):
Previously, PlagueHO (Daniel Scott-Raynsford) wrote…
Nitpick - can you add blank line before this and use single quotes around
5.0.0.0
? Also, can change[Version]
to[System.Version]
?
Done.
tests/Unit/DSC_ScheduledTask.Tests.ps1, line 1584 at r1 (raw file):
Previously, PlagueHO (Daniel Scott-Raynsford) wrote…
Nitpick - can you add blank line before this and use single quotes around
5.0.0.0
? Also, can change[Version]
to[System.Version]
?
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one minor fix (sorry about that).
Reviewed 2 of 2 files at r2, 1 of 1 files at r3.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ykuijs)
CHANGELOG.md, line 15 at r3 (raw file):
- Automatically publish documentation to GitHub Wiki - Fixes [Issue #342](https://github.com/dsccommunity/ComputerManagementDsc/issues/342). ### Fixed
Doh! Any chance you could move this block into the Unreleased section? I did a release over the weekend.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @PlagueHO)
CHANGELOG.md, line 15 at r3 (raw file):
Previously, PlagueHO (Daniel Scott-Raynsford) wrote…
Doh! Any chance you could move this block into the Unreleased section? I did a release over the weekend.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r4.
Reviewable status: complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved
Pull Request (PR) description
This PR fixes the issue where disabling certain scheduled tasks does not work.
This Pull Request (PR) fixes the following issues
Task list
Entry should say what was changed, and how that affects users (if applicable).
and comment-based help.
This change is